Skip to content

SMTChecker: Fix typo in SMTPortfolio.cpp #16025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

Conversation

gap-editor
Copy link
Contributor

I updated a comment line by removing the word "as" from:

  • "The actual logic as as follows:"
  • to
  • "The actual logic as follows:"

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@blishko
Copy link
Contributor

blishko commented Apr 28, 2025

I believe the intended wording is The actual logic is as follows:

@gap-editor
Copy link
Contributor Author

@blishko , It looks quite logical. I agree with you.

@gap-editor gap-editor changed the title remove duplicate 'as' in SMTPortfolio.cpp fix typo in SMTPortfolio.cpp Apr 28, 2025
Copy link
Contributor

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blishko blishko changed the title fix typo in SMTPortfolio.cpp SMTChecker: Fix typo in SMTPortfolio.cpp Apr 28, 2025
@blishko blishko merged commit b136829 into ethereum:develop Apr 28, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants